chore: code audit improvements and ci infrastructure - #24
Merged
Conversation
infrastructure: - add rust-toolchain.toml to pin rust 1.93 with fmt/clippy components - add .cargo/config.toml with release optimizations (lto, strip, codegen-units) - add .github/workflows/ci.yml for automated testing, linting, and security audits - add CONTRIBUTING.md with development workflow and code standards code improvements: - rewrite glob_match() with O(n*m) iterative algorithm instead of O(n²) recursive - add cursor validation in SCAN handler to guard against invalid shard_id - improve documentation for memory overhead constants and LRU sampling - document SCAN cursor encoding format (shard_id << 48 | position) - fix clippy lint (use is_multiple_of instead of % 2 != 0)
kacy
added a commit
that referenced
this pull request
Feb 11, 2026
chore: code audit improvements and ci infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive code audit addressing infrastructure gaps and code quality improvements.
Infrastructure additions
Code improvements
*a*b*c*dTest plan
Design considerations
The glob_match rewrite uses an iterative backtracking approach that:
*encountered*and tries consuming one more charThis is the same algorithm used by Redis and most shell glob implementations.